Only call torch.autocast if it will have an effect#42747
Merged
ArthurZucker merged 5 commits intohuggingface:mainfrom Dec 10, 2025
Merged
Only call torch.autocast if it will have an effect#42747ArthurZucker merged 5 commits intohuggingface:mainfrom
torch.autocast if it will have an effect#42747ArthurZucker merged 5 commits intohuggingface:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
1 task
ArthurZucker
approved these changes
Dec 10, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Perfect thanks for pushing this!
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: afmoe, apertus, arcee, aria, bamba, bitnet, blt, chameleon, cohere, cohere2, csm, cwm, dbrx, decision_transformer, deepseek_v2, deepseek_v3 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
* Only call `torch.autocast` if it will have an effect Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * whitespace Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * fixup Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * fix copies --------- Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Arthur <arthur.zucker@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a context manager to replace direct use of
torch.autocastthat only autocasts if:autocastis already enabled in this contextmaybe_autocasthasenabled=TrueThis prevents
autocastbeing added to the graph when it is effectively a no-op.Which makes graph splitting in
torch.compilemore flexible as it removes the requirement that partition IDs be monotonically increasing.